main

Possibly non-scalable portion of Squishsite.py

Lines 552 to 557 in Squishsite.py state:

def rev_id_list(self):
# """ returns reversed id list of reviewed articles """
rlist = map(None,self.ids)
rlist = filter(lambda x,p=self : p.data[x].reviewed, rlist)
rlist.reverse()
return rlist



Reading this code, it seems to me that the entire sequence of articles is returned.

This could result in Squishdot slowing down appreciably on older machines. I run Red Hat 7.3 on a 512 MB box dating from at least 2002.

It would be better to navigate the BTree using last(). Then pick only the most recent 30 articles, or whatever the maximum number of articles to be displayed is.

Then set rlist to only the reverse of those last 30 articles, instead of to every article.

Using pseudo-code

rlist = IOBtree.last()
for i in 1 to MaxArticlesDisplayed:
rlist += IOBtree.last().previous()
rlist.reverse()

This would produce a sequence of only the thirty articles that one wanted to display on the front page.

It would avoid the problem of bringing every article into memory, even those which by definition cannot be on the front page.

<  Oops... | Squishdot within Plone?  >